Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve http client builder error message #9380

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

bnoordhuis
Copy link
Contributor

Include the lower-level error message in the generic error message.

No test because I can't actually make it fail by passing it bad PEM.
I checked and reqwest::Certificate::from_pem() always returns Ok().

Fixes #9364.

Include the lower-level error message in the generic error message.

No test because I can't actually make it fail by passing it bad PEM.
I checked and `reqwest::Certificate::from_pem()` always returns `Ok()`.

Fixes denoland#9364.
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

op_crates/fetch/lib.rs Show resolved Hide resolved
@bnoordhuis bnoordhuis merged commit fb35838 into denoland:master Feb 3, 2021
@bnoordhuis bnoordhuis deleted the fix9364 branch February 3, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unable to build http client error message" when specifying CA Cert using --cert
2 participants