Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): Implement textDocument/signatureHelp #9330

Merged
merged 8 commits into from
Feb 16, 2021
Merged

feat(lsp): Implement textDocument/signatureHelp #9330

merged 8 commits into from
Feb 16, 2021

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Jan 30, 2021

Part of #8643.

@uki00a uki00a marked this pull request as ready for review January 30, 2021 15:13
@kitsonk kitsonk self-assigned this Feb 16, 2021
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit ccd6ee5 into denoland:master Feb 16, 2021
@kitsonk kitsonk mentioned this pull request Feb 16, 2021
43 tasks
@uki00a uki00a deleted the implement-textDocument/signatureHelp branch February 16, 2021 04:23
ry pushed a commit that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants