Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo publish is done manually now #9321

Merged
merged 1 commit into from
Jan 31, 2021
Merged

cargo publish is done manually now #9321

merged 1 commit into from
Jan 31, 2021

Conversation

ry
Copy link
Member

@ry ry commented Jan 29, 2021

No description provided.

@ry ry requested a review from bartlomieju January 29, 2021 16:31
@piscisaureus
Copy link
Member

Why?

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Currently only cli is automatically published which requires all other crates in the repo to be published manually. Given growing number of crates adding multiple publish steps to CI makes it even more prone to failures on releases. I'm strongly in favor of this change.

@ry ry merged commit 46d5843 into master Jan 31, 2021
@ry ry deleted the cargo-publish-ci branch January 31, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants