Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if prettier is run in lint task #93

Closed
wants to merge 2 commits into from
Closed

Check if prettier is run in lint task #93

wants to merge 2 commits into from

Conversation

mohsen1
Copy link
Contributor

@mohsen1 mohsen1 commented Jun 1, 2018 •
edited by qti3e
Loading

To avoid issues like https://github.com/ry/deno/pull/73

resolves #74

@mohsen1
Copy link
Contributor Author

mohsen1 commented Jun 1, 2018

Build is failing because of #73 :)

qti3e
qti3e approved these changes Jun 1, 2018
View reviewed changes
Copy link
Contributor

@qti3e qti3e left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : )
I can approve it's working as expected...
(it should be landed after 73)

@ry
Copy link
Member

ry commented Jun 4, 2018

This errors on the generated JS.

~/src/deno> prettier --list-different *.ts* *.js *.json
msg.pb.d.ts
msg.pb.js
Error 1 ~/src/deno>

Also let's not complicate the build scripts too much. It's fine as is. Thank you tho.

@ry ry closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qti3e qti3e qti3e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use an stricter linter
3 participants
@mohsen1 @ry @qti3e