fix(lsp): fix deadlocks, use one big mutex #9271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool, thank you. I did a quick glance and it looks good to me, but I am going to take this branch for a spin and see if I can break it. I suspect I won't be able to. |
kitsonk
approved these changes
Jan 25, 2021
The LSP code had numerous places where competing threads could take out out locks in different orders, making it very prone to deadlocks. This commit sidesteps the entire issue by switching to a single lock. The above is a little white lie: the Sources struct still uses a mutex internally to avoid having to boil the ocean (because being honest about what it does involves changing all its methods to `&mut self` but that ripples out extensively...) I'll save that one for another day.
bnoordhuis
force-pushed
the
lsp-demutox
branch
from
f5322b4
to
4bfdaef
Compare
bnoordhuis
added a commit
to bnoordhuis/deno
that referenced
this pull request
Feb 5, 2021
The mutex was used to hide the fact that the Sources object mutates itself when it's queried. Be honest about that and mark everything that directly or indirectly mutates it as `mut`. This is a follow-up to commit 2828690 from last month ("fix(lsp): fix deadlocks, use one big mutex (denoland#9271)")
bnoordhuis
added a commit
to bnoordhuis/deno
that referenced
this pull request
Feb 6, 2021
The mutex was used to hide the fact that the Sources object mutates itself when it's queried. Be honest about that and mark everything that directly or indirectly mutates it as `mut`. This is a follow-up to commit 2828690 from last month ("fix(lsp): fix deadlocks, use one big mutex (denoland#9271)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP code had numerous places where competing threads could take out
out locks in different orders, making it very prone to deadlocks.
This commit sidesteps the entire issue by switching to a single lock.
The above is a little white lie: the Sources struct still uses a mutex
internally to avoid having to boil the ocean (because being honest about
what it does involves changing all its methods to
&mut selfbut thatripples out extensively...) I'll save that one for another day.