Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary boxing of tokio::time::Sleep #9105

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Remove unnecessary boxing of tokio::time::Sleep #9105

merged 2 commits into from
Jan 13, 2021

Conversation

piscisaureus
Copy link
Member

No description provided.

piscisaureus added a commit to piscisaureus/deno that referenced this pull request Jan 13, 2021
@piscisaureus
Remove unnecessary boxing of tokio::time::Sleep (denoland#9105)
d0dd8de
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Jan 13, 2021
@piscisaureus
Fix race condition in file_watcher (denoland#9105)
e9c8195
piscisaureus added a commit to piscisaureus/deno that referenced this pull request Jan 13, 2021
@piscisaureus
Fix race condition in file watcher (denoland#9105)
21f6371
bartlomieju
bartlomieju approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bnoordhuis
bnoordhuis approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question: is the pin_project dependency necessary or convenient?

@piscisaureus
Copy link
Member Author

piscisaureus commented Jan 13, 2021 •
edited
Loading

LGTM with a question: is the pin_project dependency necessary or convenient?

Somewhere in between: it can be avoided but then we would have to manually add unsafe code to to do the projection.
Note that deno_core also depends on pin_project. Tokio seems to use pin_project_lite, which might be worth looking into.

@piscisaureus piscisaureus deleted the unbox branch January 13, 2021 19:28
@piscisaureus piscisaureus merged commit 060bfe7 into denoland:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piscisaureus @bnoordhuis @bartlomieju