refactor(op_crates/websocket): refactor event loop #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Jan 10, 2021
| @@ -294,59 +294,78 @@ | |||
| } | |||
|
|
|||
| async #eventLoop() { | |||
| if (this.#readyState === OPEN) { | |||
There was a problem hiding this comment.
This seems like a behavioral change - is something being fixed here?
There was a problem hiding this comment.
no behaviour is identical. no fixes, just a cleanup i have been meaning to do for a while.
before it was recursive calls, now just a while loop.
There was a problem hiding this comment.
Why does this if statement change to a while?
There was a problem hiding this comment.
as mentioned, it was recursive calls. that if was the guard if to get the next. since i changed to a while loop and the calls are not recursive anymore, it is equivalent. this.#readyState gets only changed if the ws closes or errors, so the loop would be exited by that changing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.