fix(runtime/websocket): respond to ping with pong #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
reviewed
Jan 3, 2021
| @@ -265,6 +267,13 @@ | |||
| event.target = this; | |||
| this.dispatchEvent(event); | |||
|
|
|||
| this.#eventLoop(); | |||
| } else if (message.type === "ping") { | |||
There was a problem hiding this comment.
This is ok for a first pass, but I think it makes sense to move this logic to Rust.
There was a problem hiding this comment.
I do plan a somewhat rewrite of websocket (mostly JS things) together with moving it to its own crate
|
I believe this might be related to issue #8972 |
|
Actually could we add a test for this? |
|
Discussed offline with @crowlKats, and tests will be added in a follow up PR (possibly using WPT). Landing this as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8972