Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): handle ts debug errors better #8914

Merged
merged 1 commit into from
Dec 30, 2020
Merged

fix(lsp): handle ts debug errors better #8914

merged 1 commit into from
Dec 30, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Dec 29, 2020

Fixes #8864

lucacasonato
lucacasonato approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice simplification

@kitsonk kitsonk merged commit e8a8172 into denoland:master Dec 30, 2020
@starkpsmichael starkpsmichael mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language server crashes when using import.meta.url
2 participants
@kitsonk @lucacasonato