-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): increase timeout duration on macOS #8733
Conversation
It failed on a test other than watcher-related ones 🤷
|
@magurotuna |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's land and see if that helps, if not I'll revert it
…enoland#8733)" This reverts commit f4cf1b4.
Unfortunately it still fails: https://github.com/denoland/deno/runs/1542414977 Reverting in #8737 |
…enoland#8733)" (denoland#8737) This reverts commit f4cf1b4.
Ref #8571
Watcher-related tests are so flaky on macOS of GitHub Actions. I'm totally unsure what the cause is. All I can confirm is the performance of macOS instance is kinda worse compared to ubuntu or windows:
https://github.community/t/macos-performance/125281
So I suspect that the flakiness is simply because of performance issues on macOS. In this PR, I'll try to see it.