Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): zsh completions #8718

Merged
merged 2 commits into from
Dec 11, 2020
Merged

fix(cli): zsh completions #8718

merged 2 commits into from
Dec 11, 2020

Conversation

crowlKats
Copy link
Member

Closes #8472

ry
ry reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to do deno completions zsh?

@crowlKats
Copy link
Member Author

maybe... this isnt an issue in clap v3 as there you cant do conflicts with non-existent args; it will not compile

@crowlKats
Copy link
Member Author

i changed the current completions test to make compeltions for zsh instead bash as this is a zsh-only issue

bartlomieju
bartlomieju approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 71d468b into denoland:master Dec 11, 2020
@carlocab carlocab mentioned this pull request Dec 11, 2020
Closed
@crowlKats crowlKats deleted the fix_zsh_completions branch December 11, 2020 18:13
@carlocab carlocab mentioned this pull request Dec 12, 2020
Closed
4 tasks
@kammoh kammoh mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zsh completion fails for 1.5.4
3 participants
@crowlKats @ry @bartlomieju