Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code: itest_ignore #8668

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Remove dead code: itest_ignore #8668

merged 1 commit into from
Dec 9, 2020

Conversation

ry
Copy link
Member

@ry ry commented Dec 8, 2020 •
edited
Loading

merge on approval

@bartlomieju
Copy link
Member

@ry are you sure you want to land it? It's gonna be a bit problematic if we'll have to ignore a test once more

@ry
Copy link
Member Author

ry commented Dec 9, 2020

It’ll be easy to find if we have to bring it back. I think we should have a policy of removing all unused code.

@ry ry merged commit f15b3d8 into denoland:master Dec 9, 2020
@ry ry deleted the remove_itest_ignore branch December 9, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ry @bartlomieju @crypt096