refactor: deno_runtime crate #8640
Conversation
bartlomieju
changed the title
bartlomieju
force-pushed
the
crate_deno_runtime
branch
from
d2ae184
to
ced32f5
Compare
Added |
| MainWorker::from_options(main_module.clone(), permissions, &options); | ||
| worker.bootstrap(&options); | ||
| worker.execute_module(&main_module).await?; | ||
| worker.run_event_loop().await?; |
There was a problem hiding this comment.
Aside: we should change the name of run_event_loop() - it's neither accurate nor descriptive. The event loop is run in tokio. This method waits until all async ops have completed. wait_for_async_ops() or something.
There was a problem hiding this comment.
We've already talked about it, ops are only one of a few things that are polled in run_event_loop, besides ops there are pending module loads and pending dynamic imports.
There was a problem hiding this comment.
wait_for_various_async_things_to_complete() then or wait_until_idle()
There was a problem hiding this comment.
wait_until_idle() sounds ok, but let's do that in other PR
| create_runtime_snapshot(&runtime_snapshot_path, js_files); | ||
| } | ||
|
|
||
| fn get_js_files(d: &str) -> Vec<PathBuf> { |
There was a problem hiding this comment.
This method is only called once, "d" is always "rt".
There was a problem hiding this comment.
Yes, it's copy paste from cli/build.rs, I suggest we do those minor cleanups in follow up PRs
This commit moves Deno JS runtime, ops, permissions and inspector implementation to new "deno_runtime" crate located in "runtime/" directory. Details in "runtime/README.md". Co-authored-by: Ryan Dahl <[email protected]>
This commit moves Deno JS runtime, ops, permissions and
inspector implementation to new "deno_runtime" crate.
Details in "runtime/README.md".
There is still some duplication of code, but overall diff is quite
small after all the recent refactors.
Closes #7928
Closes #2633