Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): remove Option from Flags.v8_flags #8633

Merged
merged 4 commits into from
Dec 6, 2020
Merged

refactor(cli): remove Option from Flags.v8_flags #8633

merged 4 commits into from
Dec 6, 2020

Conversation

crowlKats
Copy link
Member

Currently Flags.v8_flags is Option<Vec<String>>, but this can be simplified to just Vec<String> and checking for is_empty()

bartlomieju
bartlomieju approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 7135d34 into denoland:master Dec 6, 2020
@crowlKats crowlKats deleted the v8_flags_no_option branch December 6, 2020 17:43
ry
ry reviewed Dec 6, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crowlKats @ry @bartlomieju