Improve fetch #853
Merged
Improve fetch #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Sep 28, 2018
js/fetch_test.ts
Outdated
| const h = new Headers(); | ||
| } catch (e) { | ||
| assert(false, "Create headers from no parameter failed"); | ||
| } |
There was a problem hiding this comment.
You don't need try catch blocks for successful tests. The test() function already does that.
You do need to add a name to the function, because that is used in the test output. So, for example, this test should be something like:
test(function newHeadersSuccess() {
new Headers();
});
js/fetch_test.ts
Outdated
| } catch (e) { | ||
| assert(false, "Create headers from undefined parameter failed"); | ||
| } | ||
| }); |
js/fetch_test.ts
Outdated
| } catch (e) { | ||
| assert(false, "Create headers from empty object failed"); | ||
| } | ||
| }); |
| } catch (e) { | ||
| assertEqual(e.message, "Failed to construct 'Headers': Invalid value"); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Just combine all of these into one test case....
js/fetch_test.ts
Outdated
| }); | ||
| headers.forEach(function(value, key, container) { | ||
| assertEqual(headers, container); | ||
| assertEqual(value, headerEntriesDict[key]); |
There was a problem hiding this comment.
You should run ./tools/format.py too. Use arrow notation for anonymous functions.
ry
reviewed
Sep 28, 2018
js/fetch_test.ts
Outdated
| @@ -93,30 +72,30 @@ for (const name in headerDict) { | |||
| headerSeq.push([name, headerDict[name]]); | |||
| } | |||
|
|
|||
| test(function() { | |||
| test(() => { | |||
ry
reviewed
Sep 28, 2018
js/fetch_test.ts
Outdated
| const headers = new Headers(headerSeq); | ||
| for (const name in headerDict) { | ||
| assertEqual(headers.get(name), String(headerDict[name])); | ||
| } | ||
| assertEqual(headers.get("length"), null); | ||
| }); | ||
|
|
||
| test(function() { | ||
| test(() => { |
qti3e
reviewed
Sep 28, 2018
| value: init[key] | ||
| }); | ||
| } | ||
| // init is a object |
There was a problem hiding this comment.
Sorry but it's not correct, your logic fails when init is some number.
try:
new DenoHeader(5);I suggest is to do this:
if (arguments.length === 0 || init === undefined) {
return;
}
if (init instanceof DenoHeaders) {
...
} else if (Array.isArray(init)) {
...
} else if (Object.prototype.toString.call(init) === "[object Object]") {
// You can use a better is-object test if you have any : )
...
} else {
throw new TypeError("Failed to construct 'Headers': Invalid value");
}There was a problem hiding this comment.
I don't know why type check doesn't work. Maybe it is better to add more check in contructor fucntion.
qti3e
reviewed
Sep 28, 2018
| } | ||
| } | ||
|
|
||
| private normalizeParams(name: string, value?: string): string[] { | ||
| name = String(name).toLowerCase(); | ||
| value = String(value).trim(); |
There was a problem hiding this comment.
trim removes all HTTP whitespace characters? I don't know about this...
But anyway it's just fine for now
qti3e
reviewed
Sep 28, 2018
| }); | ||
| headers.forEach((value, key, container) => { | ||
| assertEqual(headers, container); | ||
| assertEqual(value, headerEntriesDict[key]); |
There was a problem hiding this comment.
What if forEach does not call the callback at all?
let call_num = 0;
headers.forEach((value, key, container) => {
++call_num;
..
});
assertEqual(call_num, keys.length)
qti3e
approved these changes
Sep 28, 2018
|
@qti3e Thanks. |
ry
approved these changes
Sep 30, 2018
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 4, 2018
- Improve fetch headers (denoland#853) - Add deno.truncate (denoland#805) - Add copyFile/copyFileSync (denoland#863) - Limit depth of output in console.log for nested objects, and add console.dir (denoland#826) - Guess extensions on extension not provided (denoland#859) - Renames: deno.platform -> deno.platform.os deno.arch -> deno.platform.arch - Upgrade TS to 3.0.3 - Add readDirSync(), readDir() - Add support for TCP servers and clients. (denoland#884) Adds deno.listen(), deno.dial(), deno.Listener and deno.Conn.
Merged
ry
added a commit
that referenced
this pull request
Oct 4, 2018
- Improve fetch headers (#853) - Add deno.truncate (#805) - Add copyFile/copyFileSync (#863) - Limit depth of output in console.log for nested objects, and add console.dir (#826) - Guess extensions on extension not provided (#859) - Renames: deno.platform -> deno.platform.os deno.arch -> deno.platform.arch - Upgrade TS to 3.0.3 - Add readDirSync(), readDir() - Add support for TCP servers and clients. (#884) Adds deno.listen(), deno.dial(), deno.Listener and deno.Conn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#522 Base on spec-whatwg and more test