Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/tools/upgrade): canary support #8476

Merged
merged 16 commits into from
Nov 29, 2020
Merged

feat(cli/tools/upgrade): canary support #8476

merged 16 commits into from
Nov 29, 2020

Conversation

crowlKats
Copy link
Member

No description provided.

bartlomieju
bartlomieju reviewed Nov 23, 2020
View reviewed changes
cli/version.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju reviewed Nov 24, 2020
View reviewed changes
cli/flags.rs
Comment on lines +958 to +960
Arg::with_name("canary")
.long("canary")
.help("Upgrade to canary builds"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this arg should take optional value that allows to specify concrete commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the current state of the PR, that would be passed through version

@lucacasonato
Copy link
Member

lucacasonato commented Nov 25, 2020 •
edited
Loading

@crowlKats Can you rebase and add a test?

@crowlKats
Copy link
Member Author

@lucacasonato sure; but currently all upgrade tests seem to be disabled because flaky

@bartlomieju
Copy link
Member

@lucacasonato sure; but currently all upgrade tests seem to be disabled because flaky

@crowlKats could you uncomment them and try to make them pass?

@crowlKats
Copy link
Member Author

not really sure what's going on... it isnt doing anything special...

@crowlKats
Copy link
Member Author

Description of current behaviour of upgrade with this PR:
to specify hash for canary, set version flag.

version specified:
stable or canary to canary: passed hash must not be same as current hash
stable to stable: same as currently (version must not be older or same as current)
canary to stable: will pass no matter what (no checks)

version not specified:
stable or canary to canary: latest hash must not be same as current hash
stable to stable: same as currently (latest version must not be older or same as current)
canary to stable: will pass no matter what (no checks)

these rules of course can be bypassed by force.

@lucacasonato
Copy link
Member

lucacasonato commented Nov 28, 2020 •
edited
Loading

The behavior looks good to me. It seems the CI failure is unrelated.

lucacasonato
lucacasonato approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @crowlKats!

@lucacasonato lucacasonato merged commit 973af61 into denoland:master Nov 29, 2020
@crowlKats crowlKats deleted the canary_upgrade branch November 29, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crowlKats @lucacasonato @bartlomieju