Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): accept get_error_class_fn in RuntimeOptions #8444

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

bartlomieju
Copy link
Member

This commit adds "get_error_class_fn" field to "RuntimeOptions"
struct in order to unify configuration of "JsRuntime".

This commit adds "get_error_class_fn" field to "RuntimeOptions"
struct in order to unify configuration of "JsRuntime".
@bartlomieju bartlomieju requested a review from ry November 20, 2020 15:28
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 04f4201 into denoland:master Nov 21, 2020
@bartlomieju bartlomieju deleted the js_runtime_class branch November 21, 2020 14:56
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
…#8444)

This commit adds "get_error_class_fn" field to "RuntimeOptions"
struct in order to unify configuration of "JsRuntime".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants