feat(std/io): ReadableStream from AsyncIterator & WritableStream from Writer #8378
Conversation
|
@crowlKats can you add some test cases? |
| /** Create a `ReadableStream` from an `AsyncIterator`. */ | ||
| export function readableStreamFromAsyncIterator<T>( | ||
| iterator: AsyncIterableIterator<T>, | ||
| ): ReadableStream<T> { |
There was a problem hiding this comment.
IMO readableStreamFromReader() should exist either way. This module exists to provide bridges between Deno IO and whatwg streams. One should be able to "expect" a readableStreamFromReader looking at the other functions.
In this case, there's no problem with having both even if one would have a trivial implementation. Similar to readLines() in std/io/bufio.ts.
There was a problem hiding this comment.
@nayeemrmn i will look into it soon; the best usage for that would a bytes ReadableStream, but still not knowledgeable about those
|
I'm missing some context on this PR... what is the purpose of these renames? |
|
This is not just renames, but rather 2 new functions: one allows to create a ReadableStream from an AsyncIterator and the other allows to create a WritableStream from a Deno.Writer. |
we should also rename
fromStreamWriter&fromStreamReadertowriterFromStreamWriter&readerFromStreamReader.Going to add tests later