fix(fmt, lint): Make sure that target paths are not directory #8375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magurotuna huge thanks for looking into this! I noticed that in |
|
@bartlomieju Oh, I missed |
|
@bartlomieju PTAL😉 |
bartlomieju
approved these changes
Nov 14, 2020
There was a problem hiding this comment.
I verified that problem described in #8374 is no longer present. Great fix and cleanup @magurotuna, thanks!
Comment on lines
+207
to
+219
| // dir.ts | ||
| // ├── a.ts | ||
| // ├── b.js | ||
| // ├── child | ||
| // │ ├── e.mjs | ||
| // │ ├── f.mjsx | ||
| // │ ├── .foo.TS | ||
| // │ └── README.md | ||
| // ├── c.tsx | ||
| // ├── d.jsx | ||
| // └── ignore | ||
| // ├── g.d.ts | ||
| // └── .gitignore |
1 task
jannes
pushed a commit
to jannes/deno
that referenced
this pull request
Dec 1, 2020
…nd#8375) This commit merges implementations of "collect_files" and "files_in_subtree", leaving only the former. Additionally it was ensured that directories are not yielded from this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8374
I'll fix more and add tests, so WIP for now.Done