Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli/tools/upgrade): rework upgrade #8331

Merged
merged 21 commits into from
Nov 22, 2020

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Nov 10, 2020

Major overhaul of upgrade, reducing complexity & giving more sensible console output. Removes gz support for archives. Uses last part of url instead of scraping to get latest version.

@crowlKats crowlKats changed the title feat(cli/upgrade): nightly support refactor(cli/tools/upgrade): rework upgrade Nov 20, 2020
@bartlomieju
Copy link
Member

@crowlKats could you prepare a commit message?

cli/tools/upgrade.rs Show resolved Hide resolved
cli/tools/upgrade.rs Outdated Show resolved Hide resolved
cli/tools/upgrade.rs Show resolved Hide resolved
cli/tools/upgrade.rs Show resolved Hide resolved
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @crowlKats

@bartlomieju bartlomieju merged commit 750f179 into denoland:master Nov 22, 2020
@crowlKats crowlKats deleted the nightly_upgrade branch November 22, 2020 15:07
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
This commit does major overhaul of "upgrade" subcommand, 
reducing complexity & giving more sensible console output. 

Removes gz support for archives. 

Uses last part of url instead of scraping to get latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants