Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/upgrade): Auto detect target triples for upgrade #8286

Merged
merged 1 commit into from
Nov 8, 2020
Merged

fix(cli/upgrade): Auto detect target triples for upgrade #8286

merged 1 commit into from
Nov 8, 2020

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Nov 7, 2020 •
edited
Loading

Should I remove the test_compose_url_to_exec test? cant see much use for it

lucacasonato
lucacasonato approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this should also fix the issue where running deno upgrade on a ARM64 system will try to download a x64 binary. Thanks

@lucacasonato lucacasonato merged commit 5995c58 into denoland:master Nov 8, 2020
@crowlKats crowlKats deleted the upgrade_get_target_triple branch November 8, 2020 11:11
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
@crowlKats @jannes
refactor: auto detect target triples for upgrade (denoland#8286)
ca9b858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crowlKats @lucacasonato