Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dlint to v0.2.10 #8284

Merged
merged 6 commits into from
Nov 14, 2020

Conversation

magurotuna
Copy link
Member

@magurotuna magurotuna commented Nov 7, 2020

require-await rule is going to be implemented in deno_lint. (denoland/deno_lint#514)
Accordingly, some parts of deno's codebase should be fixed.

  • removes unnecessary (not working) directives
  • replace eslint's directives with deno_lint's ones

This PR needs to be merged after the prebuilt dlint binary is updated, otherwise we would get the following error:

  error[ban-unknown-rule-code]: Unknown rule for code "require-await"
     --> /home/yusuktan/Repos/github.com/magurotuna/deno/std/node/_util/_util_callbackify_test.ts:363:5
      |
  363 |     // deno-lint-ignore require-await
      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      |

cc @bartlomieju

@bartlomieju bartlomieju changed the title chore(cli & std): Fix lint directives on require-await rule build: update dlint to v0.2.10 Nov 14, 2020
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @magurotuna, I've also bumped dlint to 0.2.10 in this PR

@bartlomieju bartlomieju merged commit 9029003 into denoland:master Nov 14, 2020
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Update prebuilt "dlint" binary to v0.2.10 and fix diagnostics
for "require-await" rule.

Co-authored-by: Bartek Iwańczuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants