Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to dlint #8176

Merged
merged 15 commits into from
Nov 3, 2020
Merged

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 28, 2020

@bartlomieju
Copy link
Member Author

Down to 3 errors:

dlint (513 files)
error[no-undef]: SignalStream is not defined
   --> /Users/biwanczuk/dev/deno/cli/rt/40_signals.js:165:16
    |
165 |     return new SignalStream(signo);
    |                ^^^^^^^^^^^^
    |
error[getter-return]: Expected 'body' to always return a value.
   --> /Users/biwanczuk/dev/deno/op_crates/fetch/26_fetch.js:771:5
    |
771 |       get body() {
    |  _____^
772 | |       if (this._stream) {
773 | |         return this._stream;
774 | |       }
775 | |
776 | |       if (!this._bodySource) {
777 | |         return null;
778 | |       } else if (this._bodySource instanceof ReadableStream) {
779 | |         this._stream = this._bodySource;
780 | |       } else {
781 | |         const buf = bodyToArrayBuffer(this._bodySource);
782 | |         if (!(buf instanceof ArrayBuffer)) {
783 | |           throw new Error(
784 | |             `Expected ArrayBuffer from body`,
785 | |           );
786 | |         }
787 | |
788 | |         this._stream = new ReadableStream({
789 | |           start(controller) {
790 | |             controller.enqueue(new Uint8Array(buf));
791 | |             controller.close();
792 | |           },
793 | |         });
794 | |       }
795 | |
796 | |       return this._stream;
797 | |     }
    | |______^
    |
    = help: Return a value from the getter function
error[no-undef]: HttpClient is not defined
   --> /Users/biwanczuk/dev/deno/op_crates/fetch/26_fetch.js:878:16
    |
878 |     return new HttpClient(opCreateHttpClient(options));
    |                ^^^^^^^^^^
    |
Found 3 problems

Tracked in denoland/deno_lint#462 and denoland/deno_lint#463

@bartlomieju bartlomieju changed the title [WIP] build: migrate to dlint build: migrate to dlint Nov 3, 2020
.gitmodules Outdated Show resolved Hide resolved
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally. Wow. It's very fast.

@bartlomieju bartlomieju mentioned this pull request Nov 3, 2020
@bartlomieju bartlomieju requested a review from ry November 3, 2020 15:06
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 8e914be into denoland:master Nov 3, 2020
@bartlomieju bartlomieju deleted the migrate_to_dlint branch November 3, 2020 15:19
jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
This commit migrates repository from using "eslint" 
to "dlint" for linting JavaScript code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants