Rename deno.argv, libdeno::DenoC and deno_set_flags #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Sep 22, 2018
src/libdeno.rs
Outdated
| pub fn deno_last_exception(d: *const isolate) -> *const c_char; | ||
| pub fn deno_get_data(d: *const isolate) -> *const c_void; | ||
| pub fn deno_set_response(d: *const isolate, buf: deno_buf); | ||
| pub fn deno_send(d: *const isolate, buf: deno_buf); |
There was a problem hiding this comment.
Many of these functions use the parameter name d for *const isolate. It would be better to rename this to either i or isolate_ptr.
ry
reviewed
Sep 22, 2018
src/handlers.rs
Outdated
| @@ -265,7 +265,7 @@ fn handle_code_cache(d: *const isolate, base: &msg::Base) -> Box<Op> { | |||
| }())) | |||
| } | |||
|
|
|||
| fn handle_set_env(d: *const isolate, base: &msg::Base) -> Box<Op> { | |||
| fn handle_set_env(d: *const isolate_ptr, base: &msg::Base) -> Box<Op> { | |||
There was a problem hiding this comment.
I meant the parameter name, not the type.
ry
reviewed
Sep 22, 2018
src/isolate.rs
Outdated
| @@ -76,7 +76,7 @@ impl Drop for Isolate { | |||
| } | |||
| } | |||
|
|
|||
| pub fn from_c<'a>(d: *const libdeno::DenoC) -> &'a mut Isolate { | |||
| pub fn from_c<'a>(d: *const libdeno::isolate) -> &'a mut Isolate { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#793 rename deno.argv to deno.args
#792 rename libdeno::DenoC to libdeno::isolate
#791 rename deno_set_flags to deno_set_v8_flags