Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix runtime docs link #7926

Merged
merged 2 commits into from
Oct 13, 2020
Merged

docs: fix runtime docs link #7926

merged 2 commits into from
Oct 13, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Oct 10, 2020

Fixes main README 404 link to documentation.

(Pardon the small PR, but it's quite glaring.)

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lucacasonato
Copy link
Member

Please run ./tools/format.py

@grant
docs: run formatter
6e934e1 
Signed-off-by: Grant Timmerman <[email protected]>
@grant
Copy link
Contributor Author

grant commented Oct 12, 2020

Ran:

git submodule update --init --recursive
python3 ./tools/format.py

(It's a bit weird we need python set up in this repo)

lucacasonato
lucacasonato approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :-)

@lucacasonato lucacasonato merged commit 47eeb88 into denoland:master Oct 13, 2020
@lucacasonato lucacasonato mentioned this pull request Oct 13, 2020
Closed
@grant grant deleted the patch-2 branch October 14, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grant @CLAassistant @lucacasonato