refactor(core): JsRuntime is not a Future #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit rewrites deno_core::JsRuntime to not implement Future trait. Instead there are two separate methods: - JsRuntime::poll_event_loop() - does single tick of event loop - JsRuntime::run_event_loop() - runs event loop to completion
bnoordhuis
approved these changes
Oct 7, 2020
bartlomieju
commented
Oct 7, 2020
Comment on lines
+457
to
+464
| /// Runs event loop to completion | ||
| /// | ||
| /// This future resolves when: | ||
| /// - there are no more pending dynamic imports | ||
| /// - there are no more pending ops | ||
| pub async fn run_event_loop(&mut self) -> Result<(), AnyError> { | ||
| poll_fn(|cx| self.poll_event_loop(cx)).await | ||
| } |
There was a problem hiding this comment.
@ry I still prefer run_event_loop - are you ok with it?
Comment on lines
+12
to
+17
| a way to execute JavaScript. | ||
|
|
||
| The JsRuntime implements an event loop abstraction for the executed code that | ||
| keeps track of all pending tasks (async ops, dynamic module loads). It is user's | ||
| responsibility to drive that loop by using `JsRuntime::run_event_loop` method - | ||
| it must be executed in the context of Rust's future executor (eg. tokio, smol). |
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 10, 2020
This reverts commit d8879fe.
iykekings
pushed a commit
to iykekings/deno
that referenced
this pull request
Oct 10, 2020
* Revert "refactor: Worker is not a Future (denoland#7895)" This reverts commit f4357f0. * Revert "refactor(core): JsRuntime is not a Future (denoland#7855)" This reverts commit d8879fe. * Revert "fix(core): module execution with top level await (denoland#7672)" This reverts commit c7c7677.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rewrites deno_core::JsRuntime to not implement Future
trait.
Instead there are two separate methods: