fix(websocket): add missing close events and remove extra error event #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Sep 21, 2020
There was a problem hiding this comment.
@crowlKats thanks, could you add a test case exercising this change?
|
@bartlomieju not really, as the errors that would cause these events are unexpected errors from either the client or the server. |
|
@crowlKats what about a test that counts the number of events? Wouldn't that be a sufficient test? |
|
@ry well we would need to somehow force an unexpected error to happen to test anything of the sort |
bartlomieju
changed the title
bartlomieju
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7604