Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(watch): watch importmap file for changes #7580

Merged
merged 5 commits into from
Sep 23, 2020
Merged

fix(watch): watch importmap file for changes #7580

merged 5 commits into from
Sep 23, 2020

Conversation

bartossh
Copy link
Contributor

Fixes #7519

@ry ry requested a review from bartlomieju September 21, 2020 16:53
bartlomieju
bartlomieju requested changes Sep 22, 2020
View reviewed changes
cli/import_map.rs Outdated Show resolved Hide resolved
cli/main.rs Outdated Show resolved Hide resolved
@bartossh
Copy link
Contributor Author

revert was a mistake, cleaned

bartlomieju
bartlomieju approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bartossh

@bartlomieju bartlomieju changed the title add importmap file to be watched fix(watch): watch importmap file for changes Sep 23, 2020
@bartlomieju bartlomieju merged commit 29dd62b into denoland:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support changes in import map for deno run --watch
2 participants
@bartossh @bartlomieju