Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/fmt): canonicalize files in current dir #7508

Merged
merged 5 commits into from
Sep 18, 2020
Merged

fix(cli/fmt): canonicalize files in current dir #7508

merged 5 commits into from
Sep 18, 2020

Conversation

tokiedokie
Copy link
Contributor

@tokiedokie tokiedokie commented Sep 16, 2020 •
edited
Loading

fixes #7495

ignored files and explicitly specified files are canonicalized, but files that can be traced from current_dir are not canonicalized
this causes the bug that deno lint with --ignore actually does't ignore any file

@tokiedokie tokiedokie changed the title add canonicalize() to files_in_subtree() refactor(cli/fmt): canonicalize files current dir Sep 16, 2020
@tokiedokie tokiedokie changed the title refactor(cli/fmt): canonicalize files current dir refactor(cli/fmt): canonicalize files in current dir Sep 16, 2020
@tokiedokie tokiedokie changed the title refactor(cli/fmt): canonicalize files in current dir fix(cli/fmt): canonicalize files in current dir Sep 16, 2020
@bartlomieju
Copy link
Member

@tokiedokie thanks for the PR, but it'd be great to have a test demonstrating what's being fixed. Probably the same problem applies to fmt.

@tokiedokie
Copy link
Contributor Author

tokiedokie commented Sep 16, 2020 •
edited
Loading

@bartlomieju added tests fot lint and fmt
these tests are the same to run deno lint/fmt --unstable --ignore=./ which fails on deno v1.4.0 on windows

ry
ry approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@ry ry merged commit 4c2920d into denoland:master Sep 18, 2020
@tokiedokie tokiedokie deleted the 7495 branch September 18, 2020 22:09
vitormmatos pushed a commit to vitormmatos/deno that referenced this pull request Sep 21, 2020
@tokiedokie
fix(cli/fmt): canonicalize files in current dir (denoland#7508)
9ca3879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint --ignore doesn't normalize file seperators
4 participants
@tokiedokie @bartlomieju @ry @crypt096