Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(std/uuid): remove stub implementation of v3 #7488

Merged
merged 1 commit into from
Sep 15, 2020
Merged

BREAKING(std/uuid): remove stub implementation of v3 #7488

merged 1 commit into from
Sep 15, 2020

Conversation

caspervonb
Copy link
Contributor

This removes a "not implemented" stub of uuid v3.

ry
ry approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I don't think we need to be overly scary with BREAKING messages on things people clearly aren't depending on.

@ry ry merged commit f457ff9 into denoland:master Sep 15, 2020
@caspervonb
Copy link
Contributor Author

I don't think we need to be overly scary with BREAKING messages on things people clearly aren't depending on.

Fair enough :)

caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@caspervonb
remove stub implementation of v3 in std/uuid (denoland/deno#7488)
bfc29ec
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
remove stub implementation of v3 in uuid (denoland/deno#7488)
6a06572
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
remove stub implementation of v3 in uuid (denoland/deno#7488)
fc6becc
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@caspervonb
remove stub implementation of v3 in uuid (denoland/deno#7488)
e3a4029
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
remove stub implementation of v3 in uuid (denoland/deno#7488)
8b12637
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
remove stub implementation of v3 in uuid (denoland/deno#7488)
f3be506
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb
remove stub implementation of v3 in uuid (denoland/deno#7488)
0bd8c15
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@caspervonb @denobot
remove stub implementation of v3 in uuid (denoland/deno#7488)
e360c22
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@caspervonb @denobot
remove stub implementation of v3 in uuid (denoland/deno#7488)
01a04a4
@caspervonb caspervonb deleted the breaking-std-uuid-remove-not-implemented-v3 branch May 24, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @ry