Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(std): version all imports in README #7442

Merged
merged 12 commits into from
Oct 4, 2020
Merged

docs(std): version all imports in README #7442

merged 12 commits into from
Oct 4, 2020

Conversation

tokiedokie
Copy link
Contributor

@tokiedokie tokiedokie commented Sep 13, 2020 •
edited
Loading

fixes

All imports in readme examples should be versioned, and bumped on release

in #6844

@caspervonb
Copy link
Contributor

caspervonb commented Sep 13, 2020 •
edited
Loading

Nit: tag as docs(std) please :)

@tokiedokie tokiedokie changed the title refactor(std): version all imports in README examples docs(std): version all imports in README examples Sep 13, 2020
@tokiedokie tokiedokie changed the title docs(std): version all imports in README examples docs(std): version all imports in README and JSDoc examples Sep 13, 2020
bartlomieju
bartlomieju requested changes Oct 1, 2020
View reviewed changes
std/flags/mod.ts Outdated Show resolved Hide resolved
std/archive/README.md Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Oct 1, 2020
Closed
@tokiedokie tokiedokie changed the title docs(std): version all imports in README and JSDoc examples docs(std): version all imports in README Oct 2, 2020
@bartlomieju
Copy link
Member

Blocked by denoland/dotland#1542

@tokiedokie
Copy link
Contributor Author

denoland/dotland#1542 was closed via denoland/dotland#1551

ready to merge

bartlomieju
bartlomieju requested changes Oct 4, 2020
View reviewed changes
std/datetime/README.md Show resolved Hide resolved
std/datetime/README.md Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tokiedokie, great contribution

@bartlomieju bartlomieju merged commit 3d65177 into denoland:master Oct 4, 2020
@tokiedokie tokiedokie deleted the std_versions branch October 4, 2020 14:56
JavascriptMick pushed a commit to JavascriptMick/deno that referenced this pull request Oct 5, 2020
@tokiedokie @JavascriptMick
docs(std): version all imports in README (denoland#7442)
9c4bbdc 
Use $STD_VERSION in std/ README files to automatically
display proper version.
Soremwar pushed a commit to Soremwar/deno that referenced this pull request Oct 6, 2020
@tokiedokie @Soremwar
docs(std): version all imports in README (denoland#7442)
efb31ec 
Use $STD_VERSION in std/ README files to automatically
display proper version.
@KotlinIsland
Copy link

But now the readme code samples on Github display $STD_VERSION and don't work.

@tokiedokie
Copy link
Contributor Author

@KotlinIsland Which README are you taking about?

@KotlinIsland
Copy link

KotlinIsland commented Oct 20, 2020 •
edited
Loading

Project readme

The server code sample doesn't work.

@tokiedokie
Copy link
Contributor Author

tokiedokie commented Oct 20, 2020 •
edited
Loading

@KotlinIsland This PR versions std's README.
The README you mentioned is not maintenanced in this PR, so you can open a new issue or PR.

@KotlinIsland
Copy link

That readme is the first change listed in this PR here

Github
image
deno.land
image

This is extremely confusing to someone who don't understand what this means.

@KotlinIsland KotlinIsland mentioned this pull request Oct 20, 2020
Closed
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@tokiedokie
docs(std): version all imports in README (denoland/deno#7442)
3727c9e 
Use $STD_VERSION in std/ README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@tokiedokie
docs: version all imports in README (denoland/deno#7442)
9d50abb 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@tokiedokie @caspervonb
docs: version all imports in README (denoland/deno#7442)
064decd 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@tokiedokie @caspervonb
docs: version all imports in README (denoland/deno#7442)
4f3033a 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@tokiedokie @caspervonb
docs: version all imports in README (denoland/deno#7442)
fcc2853 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@tokiedokie @caspervonb
docs: version all imports in README (denoland/deno#7442)
ef5360b 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@tokiedokie @caspervonb
docs: version all imports in README (denoland/deno#7442)
5d213ef 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@tokiedokie @denobot
docs: version all imports in README (denoland/deno#7442)
c9b8b2c 
Use $STD_VERSION in  README files to automatically
display proper version.
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@tokiedokie @denobot
docs: version all imports in README (denoland/deno#7442)
8567b96 
Use $STD_VERSION in  README files to automatically
display proper version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tokiedokie @caspervonb @bartlomieju @KotlinIsland @crypt096