Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace nested function declarations with arrow functions #7287

Merged
merged 2 commits into from
Aug 31, 2020
Merged

chore: replace nested function declarations with arrow functions #7287

merged 2 commits into from
Aug 31, 2020

Conversation

magurotuna
Copy link
Member

Resolves #7285
The no-inner-declaration rule warns nested function declarations, so replace them with arrow functions.

CC @bartlomieju

ry
ry approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@ry ry merged commit 71f0171 into denoland:master Aug 31, 2020
@magurotuna magurotuna deleted the issue7285 branch September 5, 2020 11:20
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@magurotuna
fix no-inner-declaration lint rule (denoland/deno#7287)
ed7832e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@magurotuna
fix no-inner-declaration lint rule (denoland/deno#7287)
2fa7807
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@magurotuna @caspervonb
fix no-inner-declaration lint rule (denoland/deno#7287)
fc59f32
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@magurotuna @caspervonb
fix no-inner-declaration lint rule (denoland/deno#7287)
872326e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@magurotuna @caspervonb
fix no-inner-declaration lint rule (denoland/deno#7287)
36080f6
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@magurotuna @caspervonb
fix no-inner-declaration lint rule (denoland/deno#7287)
04b14f7
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@magurotuna @caspervonb
fix no-inner-declaration lint rule (denoland/deno#7287)
d39a994
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@magurotuna @denobot
fix no-inner-declaration lint rule (denoland/deno#7287)
ef60be3
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@magurotuna @denobot
fix no-inner-declaration lint rule (denoland/deno#7287)
0d9e6a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint: no-inner-declarations will warn std & cli/tests
2 participants
@magurotuna @ry