Port writeFileSync to write_file.ts, add writeFile and tests #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside: is 644 a better permissions default (over 666)? |
ry
reviewed
Sep 11, 2018
js/write_file_test.ts
Outdated
| const enc = new TextEncoder(); | ||
| const data = enc.encode("Hello"); | ||
| const filename = "/baddir/test.txt"; | ||
| // The following should fail because /baddir doesn't exist (hopefully). |
There was a problem hiding this comment.
This comment is wrong - it fails because of permission.
There was a problem hiding this comment.
Resolved - Sorry for forgetting to update the comment
js/write_file.ts
Outdated
|
|
||
| /** | ||
| * Write a new file, with given filename and data synchronously. | ||
| * import { writeFileSync } from "deno"; |
js/write_file_test.ts
Outdated
| assertEqual("Hello", actual); | ||
| }); | ||
|
|
||
| testPerm({ write: true }, async function writeFileFail() { |
There was a problem hiding this comment.
Change test name to writeFileNotFound
kevinkassimo
force-pushed
the
fs/writeFile
branch
from
9483665
to
0e382ae
Compare
|
@hayd Both Node (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #567 (fixed, rebased and reformatted to match master requirements)
write_file.tswriteFilewriteFile