Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(url_test): disable no-self-assign rule #7204

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

magurotuna
Copy link
Member

As reported in #7193, linting by the new version of deno_lint produces the error like:

(no-self-assign) "pathname" is assigned to itself
  url.pathname = url.pathname;
                 ~~~~~~~~~~~~
    at /Users/biwanczuk/dev/deno/cli/tests/unit/url_test.ts:186:17

(no-self-assign) "pathname" is assigned to itself
  url.pathname = url.pathname;
                 ~~~~~~~~~~~~
    at /Users/biwanczuk/dev/deno/cli/tests/unit/url_test.ts:190:17

(no-self-assign) "hash" is assigned to itself
  url.hash = url.hash;
             ~~~~~~~~
    at /Users/biwanczuk/dev/deno/cli/tests/unit/url_test.ts:198:13

And according to @nayeemrmn, these self-assignments are required in order to invoke the setters, so the errors should be ignored.
So I added deno-lint-ignore no-self-assign lines.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@ry ry merged commit 6d964fc into denoland:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants