feat(std/http): Check if cookie property is valid #7189

getspooky · 2020-08-25T22:27:10Z

No description provided.

ry · 2020-08-25T23:19:26Z

Looks good - but can you add a test?

std/http/cookie_test.ts

…oStdInternalError

bartlomieju · 2020-08-27T13:32:07Z

@getspooky CI is failing, try running again by pushing empty commit: git commit -m "reset CI" --allow-empty

getspooky · 2020-08-31T19:32:09Z

@ry I added test for cookie validation

bartlomieju · 2020-09-02T10:48:23Z

@nayeemrmn PTAL

std/http/cookie.ts

bartlomieju

#7189 (comment)

…tabs, separator character

…y-new-dev

bartlomieju · 2020-11-14T13:25:10Z

@nayeemrmn @lucacasonato I think we could land this PR now, any objections?

nayeemrmn

One these are addressed we'll have a valid fix for cookie names only.

std/http/cookie.ts

Co-authored-by: Nayeem Rahman <[email protected]>

getspooky · 2020-11-16T12:05:07Z

@nayeemrmn I made the changes

nayeemrmn

LGTM

bartlomieju

LGTM as well, but I'd be great to get a few more tests

std/http/cookie_test.ts

bartlomieju

LGTM, thank you @getspooky

Co-authored-by: Nayeem Rahman <[email protected]>

getspooky changed the title ~~feat(std/http): Check if cookie propery is valid~~ feat(std/http): Check if cookie property is valid Aug 25, 2020

schwarzkopfb reviewed Aug 26, 2020

View reviewed changes

std/http/cookie_test.ts Outdated Show resolved Hide resolved

getspooky added 3 commits August 26, 2020 22:48

feat(std/http): Check if cookie propery is valid

3b32477

test(std/http): Testing Cookie propery validation

979a13b

fix(std/http): Format & Linting cookie.ts file

27b17a8

getspooky force-pushed the my-new-dev branch from 86f57de to 27b17a8 Compare August 26, 2020 21:55

getspooky added 2 commits August 27, 2020 00:09

perf(srd/http): Use assertThrows for testing cookie validation

312c823

fix(std/http): Expected error to be instance of TypeError but was Den…

3661729

…oStdInternalError

getspooky requested a review from bartlomieju August 27, 2020 13:07

reset CI

74b7a6f

nayeemrmn reviewed Sep 2, 2020

View reviewed changes

std/http/cookie.ts Outdated Show resolved Hide resolved

getspooky requested a review from lucacasonato October 17, 2020 21:14

ry added 2 commits October 26, 2020 08:43

Merge branch 'master' into my-new-dev

d23aadd

x

cc4ef6b

bartlomieju requested changes Oct 26, 2020

View reviewed changes

getspooky added 5 commits November 8, 2020 10:39

fix(srd/http): Match any US-ASCII except control characters, spaces, …

25dbc3e

…tabs, separator character

test(std/http): Cookie Validation testing

7b8721f

Merge branch 'my-new-dev' of https://github.com/getspooky/deno into m…

6c983c8

…y-new-dev

Merge remote-tracking branch 'upstream/master' into my-new-dev

087c8b8

fix(src/http): Fix linting

b9419e0

getspooky requested review from bartlomieju and kitsonk November 11, 2020 21:33

nayeemrmn requested changes Nov 14, 2020

View reviewed changes

std/http/cookie.ts Outdated Show resolved Hide resolved

std/http/cookie.ts Outdated Show resolved Hide resolved

std/http/cookie.ts Outdated Show resolved Hide resolved

std/http/cookie.ts Outdated Show resolved Hide resolved

std/http/cookie.ts Outdated Show resolved Hide resolved

getspooky and others added 2 commits November 14, 2020 21:55

fix(std/http/cookie.ts): Remove validateCookieProperty from domain

a654b6b

Co-authored-by: Nayeem Rahman <[email protected]>

fix(std/http): Remove path validateCookieProperty

163cebd

Co-authored-by: Nayeem Rahman <[email protected]>

getspooky and others added 4 commits November 14, 2020 21:57

refafator(std/http): Rename validateCookieProperty to validateCookieName

463ebf8

Co-authored-by: Nayeem Rahman <[email protected]>

fix(std/http): Use validateCookieName validation

bb534ad

Co-authored-by: Nayeem Rahman <[email protected]>

fix(std/http): Restrict to ASCII, excluding control characters

3887d42

Co-authored-by: Nayeem Rahman <[email protected]>

fix(std/http): Return cookie validation error message

0b96870

nayeemrmn approved these changes Nov 16, 2020

View reviewed changes

bartlomieju reviewed Nov 16, 2020

View reviewed changes

std/http/cookie_test.ts Outdated Show resolved Hide resolved

test(std/http): Test cookie name illegal characters

3bad681

bartlomieju approved these changes Nov 17, 2020

View reviewed changes

bartlomieju merged commit f7afe2b into denoland:master Nov 17, 2020

jannes pushed a commit to jannes/deno that referenced this pull request Dec 1, 2020

feat(std/http): Check if cookie property is valid (denoland#7189)

2ea072a

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021

feat(std/http): Check if cookie property is valid (denoland/deno#7189)

f6980e5

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

b095d5d

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

a722be9

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

9fa9be2

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

78409cf

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

b4ea488

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

7c55037

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

2227ba5

Co-authored-by: Nayeem Rahman <[email protected]>

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021

feat(http): Check if cookie property is valid (denoland/deno#7189)

39513d8

Co-authored-by: Nayeem Rahman <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(std/http): Check if cookie property is valid #7189

feat(std/http): Check if cookie property is valid #7189

getspooky commented Aug 25, 2020

ry commented Aug 25, 2020

bartlomieju commented Aug 27, 2020

getspooky commented Aug 31, 2020

bartlomieju commented Sep 2, 2020

bartlomieju left a comment

bartlomieju commented Nov 14, 2020

nayeemrmn left a comment

getspooky commented Nov 16, 2020

nayeemrmn left a comment

bartlomieju left a comment

bartlomieju left a comment

feat(std/http): Check if cookie property is valid #7189

feat(std/http): Check if cookie property is valid #7189

Conversation

getspooky commented Aug 25, 2020

ry commented Aug 25, 2020

bartlomieju commented Aug 27, 2020

getspooky commented Aug 31, 2020

bartlomieju commented Sep 2, 2020

bartlomieju left a comment

Choose a reason for hiding this comment

bartlomieju commented Nov 14, 2020

nayeemrmn left a comment

Choose a reason for hiding this comment

getspooky commented Nov 16, 2020

nayeemrmn left a comment

Choose a reason for hiding this comment

bartlomieju left a comment

Choose a reason for hiding this comment

bartlomieju left a comment

Choose a reason for hiding this comment