Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "--ignore" to deno lint #6934

Merged
merged 9 commits into from
Aug 12, 2020
Merged

feat: add "--ignore" to deno lint #6934

merged 9 commits into from
Aug 12, 2020

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Aug 1, 2020 •
edited
Loading

Adds --ignore to deno lint --unstable

Use case:

deno lint --unstable --ignore=./node_modules/

Status:
Ready for review

Ref: #6805

@littledivy littledivy marked this pull request as ready for review August 1, 2020 14:30
@littledivy littledivy changed the title [wip] feat: add "--ignore" to deno lint feat: add "--ignore" to deno lint Aug 1, 2020
@ry
Copy link
Member

ry commented Aug 3, 2020

@divy-work Thanks - looks good except we need a test of some sort.

@bartlomieju bartlomieju added this to the 1.3.0 milestone Aug 3, 2020
VamKram
VamKram reviewed Aug 6, 2020
View reviewed changes
Copy link

@VamKram VamKram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy
Copy link
Member Author

Added tests.

bartlomieju
bartlomieju approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @divy-work

bartlomieju
bartlomieju previously requested changes Aug 10, 2020
View reviewed changes
cli/flags.rs Show resolved Hide resolved
@bartlomieju bartlomieju dismissed their stale review August 12, 2020 11:03

already implemented

bartlomieju
bartlomieju approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 6706eb5 into denoland:master Aug 12, 2020
@littledivy littledivy deleted the feat/deno-lint-ignore branch August 13, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VamKram VamKram VamKram left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@littledivy @ry @bartlomieju @VamKram