Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use ts-expect-error instead of ts-ignore #6876

Merged
merged 3 commits into from
Jul 26, 2020
Merged

chore: use ts-expect-error instead of ts-ignore #6876

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
326b4f9
use ts-expect-error in _util_promisify.ts
trivikr Jul 26, 2020
d8a276f
use ts-expect-error in _util_promisify_test.ts
trivikr Jul 26, 2020
f511af1
use ts-expect-error in buffer_test.ts
trivikr Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use ts-expect-error in _util_promisify_test.ts
  • Loading branch information
@trivikr
trivikr committed Jul 26, 2020
commit d8a276f00cf291313c844c9032444341dc148770
12 changes: 6 additions & 6 deletions std/node/_util/_util_promisify_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Deno.test("Promisify.custom", async function testPromisifyCustom() {
function fn(): void {}

function promisifedFn(): void {}
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol
// @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[promisify.custom] = promisifedFn;

const promisifiedFnA = promisify(fn);
Expand All @@ -63,7 +63,7 @@ Deno.test("promiisfy.custom symbol", function testPromisifyCustomSymbol() {
// util.promisify.custom is a shared symbol which can be accessed
// as `Symbol.for("nodejs.util.promisify.custom")`.
const kCustomPromisifiedSymbol = Symbol.for("nodejs.util.promisify.custom");
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol
// @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[kCustomPromisifiedSymbol] = promisifiedFn;

assertStrictEquals(kCustomPromisifiedSymbol, promisify.custom);
Expand All @@ -73,7 +73,7 @@ Deno.test("promiisfy.custom symbol", function testPromisifyCustomSymbol() {

Deno.test("Invalid argument should throw", function testThrowInvalidArgument() {
function fn(): void {}
// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol
// @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[promisify.custom] = 42;
try {
promisify(fn);
Expand All @@ -91,7 +91,7 @@ Deno.test("Custom promisify args", async function testPromisifyCustomArgs() {
callback(null, firstValue, secondValue);
}

// @ts-ignore TypeScript (as of 3.7) does not support indexing namespaces by symbol
// @ts-expect-error TypeScript (as of 3.7) does not support indexing namespaces by symbol
fn[customPromisifyArgs] = ["first", "second"];

const obj = await promisify(fn)();
Expand Down Expand Up @@ -159,7 +159,7 @@ Deno.test(
Deno.test("Rejected value", async function testPromisifyWithAsObjectMethod() {
const o: { fn?: Function } = {};
const fn = promisify(function (cb: Function): void {
// @ts-ignore TypeScript
// @ts-expect-error TypeScript
cb(null, this === o);
});

Expand Down Expand Up @@ -220,7 +220,7 @@ Deno.test("Test error", async function testInvalidArguments() {
Deno.test("Test invalid arguments", function testInvalidArguments() {
[undefined, null, true, 0, "str", {}, [], Symbol()].forEach((input) => {
try {
// @ts-ignore TypeScript
// @ts-expect-error TypeScript
promisify(input);
} catch (e) {
assertStrictEquals(e.code, "ERR_INVALID_ARG_TYPE");
Expand Down