Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std/fs): remove unexisted imports #6850

Merged
merged 1 commit into from
Jul 23, 2020
Merged

fix(std/fs): remove unexisted imports #6850

merged 1 commit into from
Jul 23, 2020

Conversation

gera2ld
Copy link
Contributor

@gera2ld gera2ld commented Jul 23, 2020

Fix #6849

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@nayeemrmn
Copy link
Collaborator

Please add an std/fs/test.ts which contains:

import "./mod.ts";

This will cause type errors in mod.ts to be caught in CI.

@gera2ld
Copy link
Contributor Author

gera2ld commented Jul 23, 2020

done

ry
ry approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit e18e46a into denoland:master Jul 23, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@gera2ld
fix(std/fs): remove unexisted imports (denoland/deno#6850)
83bd785
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@gera2ld
fix(fs): remove unexisted imports (denoland/deno#6850)
003d892
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@gera2ld @caspervonb
fix(fs): remove unexisted imports (denoland/deno#6850)
31b3c15
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@gera2ld @caspervonb
fix(fs): remove unexisted imports (denoland/deno#6850)
c8be92c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@gera2ld @caspervonb
fix(fs): remove unexisted imports (denoland/deno#6850)
47049a8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@gera2ld @caspervonb
fix(fs): remove unexisted imports (denoland/deno#6850)
e10cd1d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@gera2ld @caspervonb
fix(fs): remove unexisted imports (denoland/deno#6850)
a7e7afe
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@gera2ld @denobot
fix(fs): remove unexisted imports (denoland/deno#6850)
be13479
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@gera2ld @denobot
fix(fs): remove unexisted imports (denoland/deno#6850)
b137171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std/fs/mod.ts is broken
4 participants
@gera2ld @CLAassistant @nayeemrmn @ry