Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(std/fs): remove readFileStr and readFileStrSync #6848

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

caspervonb
Copy link
Contributor

This removes the readFileStr and readFileStrSync functions which are effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could have combine it in the last PR

@ry
Copy link
Member

ry commented Jul 23, 2020

Please merge with master

@caspervonb
Copy link
Contributor Author

Could have combine it in the last PR

Yeah thought about it, title would have been on the really long side however so opted for a new PR 😏

@ry ry merged commit fd900cf into denoland:master Jul 23, 2020
@gera2ld gera2ld mentioned this pull request Jul 23, 2020
agm-dev added a commit to agm-dev/deno-swagger-doc that referenced this pull request Jul 24, 2020
…Sync instead"

Deno has removed those imports from std/fs/mod.ts as explained on following
pull request: denoland/deno#6848
diegoquiroz added a commit to diegoquiroz/denotrain that referenced this pull request Aug 24, 2020
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
…no#6848)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
caspervonb added a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
)

This removes the readFileStr and readFileStrSync functions which are
effectively duplicates of Deno.readTextFile and Deno.readTextFileSync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants