Remove deno_typescript #6813
Merged
Remove deno_typescript #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jul 20, 2020
Comment on lines
+80
to
+85
| fn ts_version() -> String { | ||
| let data = include_str!("typescript/package.json"); | ||
| let pkg: serde_json::Value = serde_json::from_str(data).unwrap(); | ||
| pkg["version"].as_str().unwrap().to_string() | ||
| } | ||
|
|
There was a problem hiding this comment.
IMO this is redundant and could remove build depdendency on serde and serde_json, why not just hard code it? TS update process it manual anyway
There was a problem hiding this comment.
We will forget it. I would leave it for now until we have a better approach overall to managing TypeScript (which I still think a seperate crate is the right way for the compiler.
The other way would be to return it when creating compiler snapshot as an op out with the ts.version information. That is actually more reliable. Again, something I think should be done in the compiler crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.