Upgrade to rusty_v8 0.7.0 #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
commented
Jul 18, 2020
| let context = core_state | ||
| .global_context | ||
| .as_ref() | ||
| .map(|context| v8::Local::new(scope, context)) |
There was a problem hiding this comment.
I see that in some cases it's a bit unpractical that Global::get() now deferences the handle rather than creating a new Local (which is what it used to do). I could add a method like Global::to_local() to get some of that convenience back.
andreubotella
added a commit
to andreubotella/deno
that referenced
this pull request
Mar 22, 2022
This note about how `v8::SnapshotCreator::create_blob` must not be called from a `HandleScope` stopped being relevant in denoland#6801, and was now attached to code that had nothing to do with `HandleScope`s.
bartlomieju
pushed a commit
that referenced
this pull request
Mar 22, 2022
This note about how `v8::SnapshotCreator::create_blob` must not be called from a `HandleScope` stopped being relevant in #6801, and was now attached to code that had nothing to do with `HandleScope`s.
kitsonk
pushed a commit
to kitsonk/deno
that referenced
this pull request
Mar 23, 2022
This note about how `v8::SnapshotCreator::create_blob` must not be called from a `HandleScope` stopped being relevant in denoland#6801, and was now attached to code that had nothing to do with `HandleScope`s.
kitsonk
pushed a commit
that referenced
this pull request
Mar 24, 2022
This note about how `v8::SnapshotCreator::create_blob` must not be called from a `HandleScope` stopped being relevant in #6801, and was now attached to code that had nothing to do with `HandleScope`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.