fix(std/wasi): remove number overload from rights in path_open #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagged this as a fix because it is technically fixing a defect from the spec but might make sense to consider it a refactor, isn't really observable from WASM. |
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
caspervonb
added a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fs_rights_base and fs_rights_inheriting parameters in path_open accept both number and bigint which is incorrect as these are always i64 (which is always mapped to a bigint).
This removes the offending number overloads simplifying the related code a bit.