Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tools/hyper_hello #6651

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Remove tools/hyper_hello #6651

merged 2 commits into from
Jul 6, 2020

Conversation

ry
Copy link
Member

@ry ry commented Jul 6, 2020 •
edited
Loading

This PR might cause the hyper_hello benchmark to jump. This is either because

  • the new implementation is multithreaded (but it should be configured for single thread runtime). Or,
  • the new implementation is just better

Either way, it doesn't matter much. We just want hyper_hello to act as a best case baseline for our benchmarks.

@ry ry requested a review from piscisaureus July 6, 2020 01:50
@ry ry merged commit 75d9913 into denoland:master Jul 6, 2020
@ry ry deleted the hyper_hello_cleanup2 branch July 6, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @piscisaureus