Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unstable): add Deno.fdatasyncSync and fdatasync #6403

Merged
merged 2 commits into from
Jun 26, 2020
Merged

feat(unstable): add Deno.fdatasyncSync and fdatasync #6403

merged 2 commits into from
Jun 26, 2020

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Jun 20, 2020 •
edited
Loading

This adds a new op for calling fdatasync on file streams which is exposed as Deno.fdatasyncSync and Deno.fdatasync.

Went lowercase here as I see it as a hyphened word; also Deno.fdataSyncSync has too much of an echo.

This closes #6325

@ry
Copy link
Member

ry commented Jun 21, 2020

Please merge with master

@caspervonb
Copy link
Contributor Author

caspervonb commented Jun 21, 2020 •
edited
Loading

Just saw fsync was merged, rebasing right now, hold on 😺

@caspervonb caspervonb force-pushed the fdatasync branch 2 times, most recently from 95b2301 to 11264ae Compare June 21, 2020 14:10
@bartlomieju bartlomieju added cli related to cli/ dir feat new feature (which has been agreed to/accepted) public API related to "Deno" namespace in JS labels Jun 24, 2020
ry
ry approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @caspervonb

@ry ry merged commit e278c90 into denoland:master Jun 26, 2020
@caspervonb caspervonb deleted the fdatasync branch June 26, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted) public API related to "Deno" namespace in JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for fsync and fdatasync
3 participants
@caspervonb @ry @bartlomieju