Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket Protocol and Version support #6162

Closed
wants to merge 3 commits into from
Closed

WebSocket Protocol and Version support #6162

wants to merge 3 commits into from

Conversation

Industrial
Copy link
Contributor

Hi.

These are the headers sent between client and server on the WebSocket: https://tools.ietf.org/html/rfc6455#section-11.3.5

This PR adds support for Protocol and Version headers.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2020

CLA assistant check
All committers have signed the CLA.

@Industrial
Copy link
Contributor Author

I'm not sure why the tests failed. It has nothing to do with my code, I think. What now?

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Industrial, LGTM, but please add assertions exercising this change to WS tests

@ry
Copy link
Member

ry commented Jun 10, 2020

@Industrial We have a couple flaky of rare tests at the moment - pushing an empty commit can reset a failure.

@bartlomieju
Copy link
Member

@Industrial I'm still interested in landing this PR, but to do that we'll need signed CLA and some small test case exercising new code.

@Industrial
Copy link
Contributor Author

@bartlomieju Hi, I'm currently not in the position (hit some bad times) to write the test code and I will not be for several months probably. I signed the CLA.

@bartlomieju
Copy link
Member

@bartlomieju Hi, I'm currently not in the position (hit some bad times) to write the test code and I will not be for several months probably. I signed the CLA.

@Industrial sorry to hear that. I'll add test cases, thank you for your contribution.

@bartlomieju
Copy link
Member

Closing in favor of #8505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants