Prevent circular imports in ts code

[FrancescoBorzi]

Closes: #523

[CLAassistant]

All committers have signed the CLA.

[ry]

Thanks! But before I can land this we need a tslint rule to prevent this from happening in the future too.

[FrancescoBorzi]

@ry ok. Apart from that, is the code OK? Shall we move also the export of window to a separate file?

[kt3k]

The code change seems ok to me, but CIs seem failing with the following error:

/home/travis/out/Default/deno js/unit_tests.ts --allow-write
Error: No such asset "libdeno.d.ts"
    at assert (deno/js/util.ts:20:11)
    at DenoCompiler.resolveModule (deno/js/compiler.ts:354:7)
    at DenoCompiler.resolveModuleName (deno/js/compiler.ts:398:33)
    at moduleNames.map.name (deno/js/compiler.ts:554:33)
    at Array.map (<anonymous>)
    at DenoCompiler.resolveModuleNames (deno/js/compiler.ts:545:24)
    at Object.compilerHost.resolveModuleNames (deno/third_party/node_modules/typescript/lib/typescript.js:111649:117)
    at resolveModuleNamesWorker (deno/third_party/node_modules/typescript/lib/typescript.js:82561:106)
    at resolveModuleNamesReusingOldState (deno/third_party/node_modules/typescript/lib/typescript.js:82768:24)
    at processImportedModules (deno/third_party/node_modules/typescript/lib/typescript.js:84005:35)

@ShinDarth Do you have any idea about the above error?

[FrancescoBorzi]

@kt3k fixed with e99b82f

@ry addressed in 8b569b1

[kt3k]

LGTM!

[ry]

Looks good - but don’t add the package-lock and avoid the package.json update if possible (otherwise we also need to make a change to deno_third_party)

[FrancescoBorzi]

@ry done, thanks

[ry]

LGTM - Thanks!