fix(multipart): fix error when parsing file name in utf8 format #5428

fuxingZhang · 2020-05-15T01:13:33Z

fix error "content-disposition must be set" when parsing file name in utf8 format

What happens

when i upload a file name in utf8 format, it throw an error "content-disposition must be set"

How To Reproduce

front

<!DOCTYPE html>
<html lang="en">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Document</title>
</head>

<body>
  <form method="POST" action="https://localhost:8000/form-data" enctype="multipart/form-data">
    <input type="file" name="filefield"><br />
    <input type="submit">
  </form>
</body>

</html>

deno code

import { serve } from "https://deno.land/[email protected]/http/server.ts";
import {
  MultipartReader,
} from "https://deno.land/std/mime/multipart.ts";
const s = serve({ port: 8000 });
console.log("https://localhost:8000/");

for await (const req of s) {
  const contentType = req.headers.get("content-type");
  if (!contentType || !contentType.match("multipart/form-data")) {
    throw new Error("is not multipart request");
  }
  let m = contentType.match(/boundary=([^ ]+?)$/);
  if (!m) {
    throw new Error("doesn't have boundary");
  }
  const boundary = m[1];
  const mr = new MultipartReader(req.body, boundary);
  const form = await mr.readForm();
  for (let [key, val] of form.entries()) {
    console.log({ key, val });
  }
  req.respond({ body: "success" });
}

Where is the problem

in my code

const mr = new MultipartReader(req.body, boundary) ;
mr.readForm();

=>

deno/std/mime/multipart.ts

Line 284 in 750a341

async readForm(maxMemory = 10 << 20): Promise<MultipartFormData> {

=>

deno/std/mime/multipart.ts

Line 290 in 750a341

const p = await this.nextPart();

=>

deno/std/mime/multipart.ts

Line 371 in 750a341

const headers = await r.readMIMEHeader();

=>

deno/std/textproto/mod.ts

Line 51 in 750a341

async readMIMEHeader(): Promise<Headers | null> {

in readMIMEHeader

deno/std/textproto/mod.ts

Line 52 in 750a341

const m = new Headers();

deno/std/textproto/mod.ts

Line 110 in 750a341

m.append(key, value);

No problem when the encoding of the value is ASCII.
But it is ignored when the value is in utf8 format( When the file name of the uploaded file is in utf8 format，the value is "form-data; name="filefield"; filename="微信图片_20200211090118.png")

in getContentDispositionParams

deno/std/mime/multipart.ts

Line 206 in 750a341

const cd = this.headers.get("content-disposition");

cd is null,
so i get error "content-disposition must be set" When executed to

deno/std/mime/multipart.ts

Line 208 in 750a341

assert(cd != null, "content-disposition must be set");

CLAassistant · 2020-05-15T01:13:37Z

All committers have signed the CLA.

ry

Thanks for the patch!

I wonder if you could provide a test case that demonstrates the failure you're seeing?

Also CI is failing on lint/formatting. You can fix these by running ./tools/lint.py --js and ./tools/format.py --js.

fuxingZhang · 2020-05-16T05:48:48Z

Thanks for the patch!

I wonder if you could provide a test case that demonstrates the failure you're seeing?

Also CI is failing on lint/formatting. You can fix these by running ./tools/lint.py --js and ./tools/format.py --js.

Thanks for your help!
I have added unit test and format my code.

ry

LGTM - thanks!

…land/deno#5428)

fix(multipart): fix error when parsing file name in utf8 format

8e0404b

add parameter type

cf038f3

ry reviewed May 15, 2020

View reviewed changes

bartlomieju added the std label May 15, 2020

fuxingZhang added 2 commits May 16, 2020 12:01

Add unit test

78cfd8a

format code

a56fefb

fuxingZhang added 4 commits May 16, 2020 16:10

use encodeURIComponent, decodeURIComponent

a005502

fix: just encode invalid header char

569b455

change comment

99bbfd8

fix regular

35726bd

fuxingZhang requested a review from ry May 18, 2020 01:19

ry approved these changes May 19, 2020

View reviewed changes

ry merged commit 7589d4d into denoland:master May 19, 2020

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

a409834

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

dfc6338

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

7b6227b

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

cde9bc6

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

f5e27c9

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

222914d

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

09c76a6

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

07c544b

…land/deno#5428)

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021

fix(multipart): fix error when parsing file name in utf8 format (deno…

2be706a

…land/deno#5428)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(multipart): fix error when parsing file name in utf8 format #5428

fix(multipart): fix error when parsing file name in utf8 format #5428

fuxingZhang commented May 15, 2020 •

edited

Loading

CLAassistant commented May 15, 2020 •

edited

Loading

ry left a comment

fuxingZhang commented May 16, 2020

ry left a comment

fix(multipart): fix error when parsing file name in utf8 format #5428

fix(multipart): fix error when parsing file name in utf8 format #5428

Conversation

fuxingZhang commented May 15, 2020 • edited Loading

What happens

How To Reproduce

Where is the problem

CLAassistant commented May 15, 2020 • edited Loading

ry left a comment

Choose a reason for hiding this comment

fuxingZhang commented May 16, 2020

ry left a comment

Choose a reason for hiding this comment

fuxingZhang commented May 15, 2020 •

edited

Loading

CLAassistant commented May 15, 2020 •

edited

Loading