Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #5329: Misleading code in Manual - Program Lifecycle section #5332

Merged
merged 2 commits into from
May 15, 2020
Merged

Fix for #5329: Misleading code in Manual - Program Lifecycle section #5332

merged 2 commits into from
May 15, 2020

Conversation

maxxxymum
Copy link
Contributor

@maxxxymum maxxxymum commented May 14, 2020 •
edited
Loading

This PR is fix for #5329

I have added missing console.log("log from main script") to code example. Now output in console matches code provided by example

@CLAassistant
Copy link

CLAassistant commented May 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ry
Copy link
Member

ry commented May 14, 2020

You've unfortunately hit a flaky test (#5275). If you restart the build (git commit --allow-empty -m bump && git push) it ought to fix it.

@maxxxymum
Copy link
Contributor Author

@ry Thx for help, I will try it now

ry
ry approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@ry ry merged commit d4afc98 into denoland:master May 15, 2020
@ry ry mentioned this pull request May 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxxxymum @CLAassistant @ry