refactor(fs): use every instead of reduce #5323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The previous usage of `reduce` was basically implementing the [`every` function](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/every). A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
|
(force pushed to fix formatting 😬) |
garethallenstringer
approved these changes
May 14, 2020
erikknaake
approved these changes
May 15, 2020
bartlomieju
approved these changes
May 15, 2020
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 21, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 24, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Jan 31, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
caspervonb
pushed a commit
to caspervonb/deno_std
that referenced
this pull request
Feb 1, 2021
The previous usage of `reduce` was basically implementing the `every` A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous usage of
reducewas basically implementing theeveryfunction. A small difference is that the new implementation will stop checking as soon as one element have returned false, which will reduce the number of unnecessary checks.