Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allow-read to file-server debugger example #5282

Merged
merged 2 commits into from
May 13, 2020
Merged

Add allow-read to file-server debugger example #5282

merged 2 commits into from
May 13, 2020

Conversation

KluVerKamp
Copy link
Contributor

@KluVerKamp KluVerKamp commented May 13, 2020 •
edited

file-server requires read permission to work
cc @bartlomieju

bartlomieju
bartlomieju approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, my bad! Thanks @KluVerKamp!

@KluVerKamp
Copy link
Contributor Author

--allow-net is needed as well, ooops

@ry ry merged commit 38e253e into denoland:master May 13, 2020
@KluVerKamp KluVerKamp deleted the patch-2 branch May 14, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KluVerKamp @bartlomieju @ry